Make dbal config: "server_version" configurable

The server version must now be set in the parameters.yml. A sensible
default is provided in the parameters.yml.dist.

Author: MKodde

CHANGELOG.md

@@ -1,5 +1,8 @@
 # Changelog
 
+## Develop
+* The previously hardcoded "server_version" config option (Doctrine DBAL) is now configurable
+
 ## 2.9.1
 **Bugfix**
 * Resolve a Doctrine DBAL configuration issue described in https://github.com/doctrine/DoctrineBundle/issues/351

app/config/config.yml

@@ -72,7 +72,7 @@ doctrine:
                 dbname:   "%database_middleware_name%"
                 user:     "%database_middleware_user%"
                 password: "%database_middleware_password%"
-                server_version: '5.6'
+                server_version: "%database_server_version%"
                 charset:  UTF8
             gateway:
                 driver:   "%database_driver%"
@@ -81,7 +81,7 @@ doctrine:
                 dbname:   "%database_gateway_name%"
                 user:     "%database_gateway_user%"
                 password: "%database_gateway_password%"
-                server_version: '5.6'
+                server_version: "%database_server_version%"
                 charset:  UTF8
             deploy:
                 driver:   "%database_driver%"
@@ -90,7 +90,7 @@ doctrine:
                 dbname:   "%database_middleware_name%"
                 user:     "%database_deploy_user%"
                 password: "%database_deploy_password%"
-                server_version: '5.6'
+                server_version: "%database_server_version%"
                 charset:  UTF8
         types:
             authority_role: Surfnet\StepupMiddleware\ApiBundle\Doctrine\Type\AuthorityRoleType

app/config/parameters.yml.dist

@@ -2,6 +2,10 @@ parameters:
     database_driver:   pdo_mysql
     database_host:     10.10.0.100
     database_port:     ~
+    # The database server version is used in the dbal configuration and is required to prevent issues when the database
+    # connection is booted. See https://github.com/doctrine/DoctrineBundle/issues/351 for more details on this.
+    # Also see: https://symfony.com/doc/current/reference/configuration/doctrine.html#doctrine-dbal-configuration
+    database_server_version: 5.6
     database_middleware_name:     middleware
     database_middleware_user:     middleware
     database_middleware_password: middleware