Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSV import is buggy #7992

Closed
nino-filigran opened this issue Aug 8, 2024 · 3 comments
Closed

CSV import is buggy #7992

nino-filigran opened this issue Aug 8, 2024 · 3 comments
Labels
bug use for describing something not working as expected csv mapper Linked to csv mapper feature solved use to identify issue that has been solved (must be linked to the solving PR)
Milestone

Comments

@nino-filigran
Copy link

nino-filigran commented Aug 8, 2024

Description

When trying to import data through the CSV, the output of the import in the UI displays that the import is successuful but the value is = null/amount of entities to be ingested (ex: null/7)

However when navigating to the type of entities I've tried to import, I find them. And when navigating back to the data/import, I see the correct number.
I basically need to refresh the page to see updates. And sometimes, I even need to refresh 2 or 3 times to see the sucessful result.

Environment

Demo public & internal

Reproducible Steps

Steps to create the smallest reproducible scenario:

  1. Create a CSV mapper
  2. Upload the CSV
  3. Import the CSV

Expected Output

If the import is successful, I expect to see the correct number of entities (ex 5/5)

Actual Output

Null/5 in that specific case

Additional information

CSV mapper:
image (4)
image (3)
image (2)

CSV file:
test_csv_5 (2).csv

Screenshots (optional)

In the following video, we see that I successfully find the needed observables

Recording.2024-08-08.153829.mp4
@nino-filigran nino-filigran added bug use for describing something not working as expected needs triage use to identify issue needing triage from Filigran Product team and removed needs triage use to identify issue needing triage from Filigran Product team labels Aug 8, 2024
@nino-filigran nino-filigran added this to the Bugs backlog milestone Aug 12, 2024
@nino-filigran nino-filigran added the csv mapper Linked to csv mapper feature label Aug 12, 2024
@frapuks
Copy link
Member

frapuks commented Aug 14, 2024

At 00:27, you have the update (just before your refresh), null/7 is changed by 7/7.
That i understanded about this, you have 3 steps :

  • Loader : during the bundle creation with csv elements
  • null/7 (or null/x) : when the bundle are sended to the worker
  • 7/7 (or x/7) : when the worker has finished

I think it's not a bug, it's just the delay

@nino-filigran
Copy link
Author

But then, don't you find it weird to display a success even if it's null/X? I think it would make more sense to show a loader for both step 1 & 2 and only show the result when the worker has finished. I've created this bug a user asked us why it's import was marked as null/7 (and therefore not finding the 7 entities in the platform) even though it's sucessful.

@CelineSebe
Copy link
Member

It seems this issue no longer exists

@SamuelHassine SamuelHassine added the solved use to identify issue that has been solved (must be linked to the solving PR) label Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug use for describing something not working as expected csv mapper Linked to csv mapper feature solved use to identify issue that has been solved (must be linked to the solving PR)
Projects
None yet
Development

No branches or pull requests

5 participants