Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Task: Buchwald-Hartwig yield prediction data #80

Open
pschwllr opened this issue Mar 8, 2023 · 2 comments · May be fixed by #81
Open

New Task: Buchwald-Hartwig yield prediction data #80

pschwllr opened this issue Mar 8, 2023 · 2 comments · May be fixed by #81

Comments

@pschwllr
Copy link
Contributor

pschwllr commented Mar 8, 2023

Data from https://www.science.org/doi/10.1126/science.aar5169 for reaction yield prediction task.

I will take care of that.

@pschwllr
Copy link
Contributor Author

pschwllr commented Mar 8, 2023

image

The reaction can be either represented through a single column reaction_SMILES or using four columns (ligand, ...).

@kjappelbaum how do you want me to include this information?

@pschwllr pschwllr linked a pull request Mar 8, 2023 that will close this issue
@kjappelbaum kjappelbaum linked a pull request Mar 9, 2023 that will close this issue
@kjappelbaum
Copy link
Collaborator

Hey! Thanks for looking into this!

I think it would be good to have the rxn SMILES as an identifier such that we can aggregate on this across all rxn datasets. However, for rxns, I would go via prompt templates that you can specify in the yml. That is, we would, by default, sample a prompt that uses rxn-SMILES and one of the targets (here yield) to construct a prompt. However, you might suggest more that leverage the structure of this dataset.

I can later (this weekend) commit an example of this to your PR if this helps!

Thanks, again 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants