Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Brazilian grades #98

Open
1 of 5 tasks
musoke opened this issue Apr 24, 2023 · 3 comments · Fixed by #158
Open
1 of 5 tasks

add Brazilian grades #98

musoke opened this issue Apr 24, 2023 · 3 comments · Fixed by #158
Labels
enhancement New feature or request
Milestone

Comments

@vnugent vnugent added this to the Next milestone Apr 27, 2023
@musoke musoke added the enhancement New feature or request label Jun 7, 2023
@musoke musoke linked a pull request Nov 9, 2023 that will close this issue
@musoke musoke changed the title add Brazilian grades add BrazilianCrux grades Nov 9, 2023
@musoke musoke changed the title add BrazilianCrux grades add Brazilian grades Nov 10, 2023
@musoke
Copy link
Collaborator Author

musoke commented Nov 10, 2023

We have started Brazilian grades, but there are more layers

@musoke musoke reopened this Nov 10, 2023
@musoke
Copy link
Collaborator Author

musoke commented Nov 10, 2023

https://github.com/OpenBeta/sandbag/pull/158/files#r1388446690

Yeah, to make it as brief as possible: the brazilian grade standard actually has two grades for any route that IS NOT a single pitch/sports route:

the general grade of the route
the grade of the hardest move (crux)

for the general grade, an arabic number is used: i.e. 6th
for the crux grade, it's roman. so a route that is generally graded in 5th grade but has a 6sup grade crux, it reads like:
5º 6sup5º VIsup

for sports climb/single pitch, we use only the second form because there's no point in having two assignments.
I have focused my implementation in just the second form. However, later we could expand to enable the whole aspect of the brazilian specification, which has more to it: duration, aid grade, exposition grade.

@musoke
Copy link
Collaborator Author

musoke commented Nov 10, 2023

https://github.com/OpenBeta/sandbag/pull/158/files#r1388568954

I have focused my implementation in just the second form. However, later we could expand to enable the whole aspect of the brazilian specification, which has more to it: duration, aid grade, exposition grade.

Yes, makes sense to start with the common case.

We will need a system to handle this for other scales too. I haven't worked out the details, but I plan to allow hybrid/combined grades that combine complementary scales. For example, a British trad grade could be constructed from a grade on each of the adjectival and technical scales, e.g. BritishAdjectival("E6") + BritishTechnical("6a"). Likewise, an aid route with mandatory climbing could get a grade of 5.8 A1 , which would be parsed as Aid("A1") + YosemiteDecimal("5.5").

If I understand the spec you shared, most Brazilian grades would be represented by a combination of

BrazilianGeneral ~ [1º, 2º, 3º, 4º, 5º, 6º, 7º, 8º,…]
BrazilianTechnical ~ ['I', 'Isup', 'II', 'IIsup',...] <- this PR
BrazilianAid == Aid?
BrazilianDuration ~ ['D1', 'D2', ..., 'D7']
BrazilianExposure ~ ['E1', 'E2', ..., 'E5']

Does this general idea make sense for Brazilian grades?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants