New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

convert CSV to JSON at runtime #121

Open

musoke opened this issue Jun 7, 2023 · 0 comments

Labels

Milestone

Collaborator

musoke commented Jun 7, 2023 •

edited

Loading

Currently, https://github.com/OpenBeta/sandbag/blob/f3e46f8d6855a614cdf59138d0b9d9829f9efcca/src/data/csvtojson.ts is used during development to convert CSV files of grade tables to JSON. I think this should happen at run time instead. This would have benefits including

fewer steps for developers
fixes test csvtojson in CI #120
fewer irrelevant lines in diffs
sandbag could use user-defined tables, possibly even linking a sheet in the "cloud". (This would be low priority.)
The CSVs included with sandbag would remain as the canonical conversion tables.

Possible issues

Latency. Should check with https://github.com/openBeta/open-tacos and https://github.com/OpenBeta/openbeta-graphql/.

musoke added the enhancement label

musoke added this to the Next milestone

musoke modified the milestones: Next, M10

This was referenced Jun 20, 2023

importing sandbag in openbeta-graphql is broken #123

Closed

convert csv to json at run time #127

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment