Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Submit PR to open deepsourcelabs/good-first-issue to be added to their website #656

Closed
clintonlunn opened this issue Jan 19, 2023 · 7 comments
Closed

Submit PR to open deepsourcelabs/good-first-issue to be added to their website #656

clintonlunn opened this issue Jan 19, 2023 · 7 comments
Assignees
@vcbenj
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Milestone
v0.7

Comments

@clintonlunn
Copy link
Collaborator

clintonlunn commented Jan 19, 2023 •
edited
Loading

When I google search "good first issue", https://goodfirstissue.dev/ is the first result (for me).

They have a process outlined in their README.md to get added to their site and promoted and I think it might help us attract more contributors.
@clintonlunn clintonlunn changed the title Submit PR to open [deepsourcelabs/good-first-issue](https://github.com/deepsourcelabs/good-first-issue) to be added to their website Submit PR to open deepsourcelabs/good-first-issue to be added to their website Jan 19, 2023
@vnugent vnugent added this to the v0.7 milestone Jan 28, 2023
@vnugent vnugent mentioned this issue Jan 28, 2023
Open
25 tasks
@vnugent vnugent added help wanted Extra attention is needed good first issue Good for newcomers and removed need decision labels Feb 8, 2023
@vcbenj
Copy link

vcbenj commented Feb 8, 2023

Hey I can take on this ticket

@vcbenj
Copy link

vcbenj commented Feb 13, 2023

@vnugent I sent a pr a few days ago and now we are just waiting to hear back. It looks like they haven't merged anything since October so it could be a bit.

@vcbenj
Copy link

vcbenj commented Feb 13, 2023

Here's the link to my PR DeepSourceCorp/good-first-issue#552

@vnugent
Copy link
Contributor

vnugent commented Feb 13, 2023

@all-contributors add @vcbenj for code

@allcontributors allcontributors bot mentioned this issue Feb 13, 2023
Merged
@allcontributors
Copy link
Contributor

@vnugent

I've put up a pull request to add @vcbenj! 🎉

@vnugent
Copy link
Contributor

vnugent commented Feb 14, 2023

Thanks @vcbenj. What do you think if we leave this issue open until they merge the PR?

@vnugent vnugent mentioned this issue Mar 3, 2023
Open
21 tasks
@vnugent vnugent mentioned this issue Apr 22, 2023
Closed
19 tasks
@zichongkao
Copy link
Contributor

Finally done! https://github.com/DeepSourceCorp/good-first-issue/pull/552/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vcbenj vcbenj

Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
v0.7
Development

No branches or pull requests
4 participants
@zichongkao @vnugent @clintonlunn @vcbenj