-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BugFix] Fix Tests & Related Bugs #6657
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to bugfix/pre-release-fixes
…finance/OpenBB into bugfix/pre-release-fixes
IgorWounds
reviewed
Sep 6, 2024
IgorWounds
reviewed
Sep 6, 2024
IgorWounds
previously requested changes
Sep 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd edit the start and end dates and re-record the cassettes.
These are integration tests, no cassettes here. |
jmaslek
approved these changes
Sep 6, 2024
deeleeramone
dismissed
IgorWounds’s stale review
September 6, 2024 22:29
Integration tests are not cassette-based.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?:
What?:
openbb-cftc
.equity.estimates.forward_eps
andforward_sales
.openbb-charting
, andopenbb-cli
, where cells containing arrays result in no table being rendered in a white window.obb.news.world
openbb-intrinio
, with,equity.calendar.ipo
Impact:
Testing Done: