Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Improve Warning For Invalid Defaults Key In user_settings.json #6651

Merged
merged 2 commits into from
Sep 5, 2024

Conversation

deeleeramone
Copy link
Contributor

  1. Why?:

    • Adds clarity and actionable information to the warning.
  2. What? (1-3 sentences or a bullet point list):

    • Suppressed if "routes" is actually empty and/or when show_warnings is set to false.
  3. Impact:

    • Annoying warning will no longer display if the user happens to have a legacy user_settings.json file with this key.
    • The warning will be broadcast only when routes is actually populated
  4. Testing Done:

    • Play around with user_settings.json to show and suppress the warning.

@deeleeramone deeleeramone added bug Fix bug platform OpenBB Platform labels Sep 4, 2024
@deeleeramone deeleeramone requested a review from piiq September 4, 2024 17:22
@github-actions github-actions bot added the v4 PRs for v4 label Sep 4, 2024
@piiq piiq added this pull request to the merge queue Sep 5, 2024
Merged via the queue into develop with commit 53b6471 Sep 5, 2024
10 checks passed
@piiq piiq deleted the bugfix/defaults-deprecation-warning branch September 5, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug platform OpenBB Platform v4 PRs for v4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants