Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Raise EmptyDataError When No Results Returned From obb.economy.fred_search() #6592

Merged
merged 1 commit into from
Jul 18, 2024
Merged

[BugFix] Raise EmptyDataError When No Results Returned From obb.economy.fred_search() #6592

merged 1 commit into from
Jul 18, 2024

Conversation

deeleeramone
Copy link
Contributor

  1. Why?:

    • ^
    • API does not like an empty data response and will return a confusing 500 error.

  2. What?:

    • raise EmptyDataError() when the search results return nothing.

  3. Impact:

    • Will now raise instead of returning an empty list.

  4. Testing Done:

    • Observed the error is being raised as expected.

@deeleeramone deeleeramone added bug Fix bug platform OpenBB Platform v4 PRs for v4 labels Jul 17, 2024
@deeleeramone deeleeramone requested a review from IgorWounds July 17, 2024 19:01
@deeleeramone deeleeramone marked this pull request as ready for review July 17, 2024 19:01
@IgorWounds IgorWounds added this pull request to the merge queue Jul 18, 2024
Merged via the queue into develop with commit 6deabd7 Jul 18, 2024
13 checks passed
@IgorWounds IgorWounds deleted the bugfix/empty-fred-search-results branch July 19, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IgorWounds IgorWounds IgorWounds approved these changes

Assignees
No one assigned
Labels
bug Fix bug platform OpenBB Platform v4 PRs for v4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deeleeramone @IgorWounds