Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Fix FMP Currency/Crypto Historical Prices #6383

Merged
merged 2 commits into from
May 9, 2024
Merged

[BugFix] Fix FMP Currency/Crypto Historical Prices #6383

merged 2 commits into from
May 9, 2024

Conversation

deeleeramone
Copy link
Contributor

  1. Why?:

    • API endpoint changed without warning or messages.

  2. What?:

    • Updated the request URLs to a working path.
    • Recaptured unit tests.

  3. Impact (1-2 sentences or a bullet point list):

    • N/A

  4. Testing Done:

    • Currency/Crypto historical prices not returning empty now.

Screenshot 2024-05-09 at 8 40 45 AM

@deeleeramone deeleeramone added bug Fix bug platform OpenBB Platform v4 PRs for v4 labels May 9, 2024
@deeleeramone deeleeramone requested a review from IgorWounds May 9, 2024 15:41
@IgorWounds IgorWounds enabled auto-merge May 9, 2024 19:55
@IgorWounds IgorWounds added this pull request to the merge queue May 9, 2024
Merged via the queue into develop with commit 9bdc0f1 May 9, 2024
10 checks passed
@IgorWounds IgorWounds deleted the bugfix/fmp-historical branch May 10, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IgorWounds IgorWounds IgorWounds approved these changes

Assignees
No one assigned
Labels
bug Fix bug platform OpenBB Platform v4 PRs for v4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deeleeramone @IgorWounds