Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] Add trait static property accessors/mutators #24

Closed
feltech opened this issue Mar 22, 2023 · 1 comment
Closed

[Core] Add trait static property accessors/mutators #24

feltech opened this issue Mar 22, 2023 · 1 comment
Labels
good first issue Good for newcomers

Comments

@feltech
Copy link
Member

feltech commented Mar 22, 2023

What

Add static variants of trait property accessors and mutators, e.g. getMyPropertyFrom(traitsData) / setMyPropertyTo(traitsData)

Why

Currently trait view classes require construction around a TraitsDataPtr before property accessors/mutators can be used. This involves a copy-construction of the TraitsDataPtr. If the user only cares to query a particular property, then that copy-construction is a waste of resources.

Note that we already have static variants of imbue/isImbued, i.e. imbueTo/isImbuedTo, so doing similar for properties adds some functional parity.
@elliotcmorris elliotcmorris added the good first issue Good for newcomers label Jan 23, 2024
@elliotcmorris
Copy link
Contributor

Dupe of #35

@elliotcmorris elliotcmorris closed this as not planned Won't fix, can't repro, duplicate, stale Apr 19, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Done in OpenAssetIO Development Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
OpenAssetIO Development
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@feltech @elliotcmorris