-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[typescript] Default auth method support and optional param object when all params optional #11321
[typescript] Default auth method support and optional param object when all params optional #11321
Conversation
I'm happy to split this into two separate PR's if this is too messy btw |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the pull request! :)
I think we can keep it as 1 PR - it's not messy at all and quite easy to read & understand.
Added a couple comments with questions and a small change.
samples/openapi3/client/petstore/typescript/builds/default/types/ObjectParamAPI.ts
Outdated
Show resolved
Hide resolved
modules/openapi-generator/src/main/resources/typescript/api/api.mustache
Outdated
Show resolved
Hide resolved
modules/openapi-generator/src/main/resources/typescript/api/api.mustache
Outdated
Show resolved
Hide resolved
i've moved the |
ive excluded the inversify portion since the injection was essentially a whole separate feature |
Really looking forward to this change 😄. |
LGTM! Many thanks for the PR! :) |
Add an optional
default?: SecurityAuthentication
field to theAuthMethodsConfiguration
type that populates a similarly typed optional field on theAuthMethods
type.This enables passing a custom object satisfying the
SecurityAuthentication
interface for authentication purposes in the config either when a client is created or overriding at api call time via config param.Also carry over optional singleParameter when all params optional from here
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
(5.3.0),6.0.x
@TiFu @taxpon @sebastianhaas @kenisteward @Vrolijkx @macjohnny @topce @akehir @petejohansonxo @amakhrov