Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Symfony] [spec 3.0] No support for API keys in Cookies #875

Closed
Addvilz opened this issue Aug 22, 2018 · 1 comment
Closed

[Symfony] [spec 3.0] No support for API keys in Cookies #875

Addvilz opened this issue Aug 22, 2018 · 1 comment

Comments

@Addvilz
Copy link
Contributor

Addvilz commented Aug 22, 2018

Description

Symfony code generator lacks support for API keys in cookies as per 3.0+ spec.

In addition to that, generated code does not fail gracefully either, instead just skipping the definition of the variable. That leads to runtime errors if left unchecked.

https://github.com/OpenAPITools/openapi-generator/blob/master/modules/openapi-generator/src/main/resources/php-symfony/api_controller.mustache#L79

openapi-generator version

Affects all (issue is present in master and 4x)

Suggest a fix/enhancement

Fix should be trivial to implement in the template directly, but I have yet to confirm that in reality.

I will open a PR on this issue as soon as I get a chance (tomorrow or in next couple of days).

@wing328
Copy link
Member

wing328 commented Aug 24, 2018

Closed via #884

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants