Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] PlantUML generation produces a lot of warnings #7070

Closed
5 of 6 tasks
typhoon2k opened this issue Jul 29, 2020 · 3 comments · Fixed by #7071
Closed
5 of 6 tasks

[BUG] PlantUML generation produces a lot of warnings #7070

typhoon2k opened this issue Jul 29, 2020 · 3 comments · Fixed by #7071

Comments

@typhoon2k
Copy link
Contributor

Bug Report Checklist

  • Have you provided a full/minimal spec to reproduce the issue?
  • Have you validated the input using an OpenAPI validator (example)?
  • What's the version of OpenAPI Generator used?
  • Have you search for related issues/PRs?
  • What's the actual output vs expected output?
  • [Optional] Bounty to sponsor the fix (example)
Description

When running plantuml generation we are getting a lot of these 2 warnings:

[main] WARN o.o.codegen.DefaultCodegen - escapeQuotationMark should be overridden in the code generator with proper logic to escape single/double quote
[main] WARN o.o.codegen.DefaultCodegen - escapeUnsafeCharacters should be overridden in the code generator with proper logic to escape unsafe characters

openapi-generator version

5.0.0-beta

OpenAPI declaration file content or url

petstore.yaml can be used to repeat this problem.

Command line used for generation
    java \
        -jar openapi-generator-cli-5.0.0-beta.jar \
            generate \
            --input-spec $input_file \
            --generator-name plantuml \
            --output $output_folder
Steps to reproduce
  1. run generator
  2. check logs
Related issues/PRs

N/A

Suggest a fix

Provide overrides for escapeQuotationMark and escapeUnsafeCharacters.

@wing328
Copy link
Member

wing328 commented Jul 29, 2020

@typhoon2k thanks for reporting the issue. I've filed #7071 to fix it.

@wing328
Copy link
Member

wing328 commented Jul 29, 2020

@typhoon2k fixed. Please pull the latest master to give it another try.

@typhoon2k
Copy link
Contributor Author

Looks good now, there are no warnings anymore. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants