-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG][DART] Bad support for extension x-enum-varnames #5794
Comments
👍 Thanks for opening this issue! The team will review the labels and make any necessary changes. |
I had a look a the generator and found out by trial and error that removing the following method fixes the problem. Lines 458 to 470 in 11a674f
But there must be reason, why the method was overridden from the default generator. Can you remember it @pylaligand and @wing328? (Thanks to git blame^^) I couldn't find any during my short test. Is maybe "x-enum-values" missing then? If that's the problem, I would vote for #1486 which seem to solve the problem for all generators and we can remove this overriding (and some methods which will then be unused). I would even say, we should remove these methods regardless the PR to be consistent with the other generators which seem to support only "x-enum-varnames" and not "x-enum-values". |
AFAIR yes that was to support |
Can you try this again on master? |
Description
Enums that has the
x-enum-varnames
extension defined are not processed correctly and the enum var names seems to be generated automatically instead of get the names defined.openapi-generator version
OpenAPI declaration file content or url
Command line used for generation
Steps to reproduce
Just copy the .yml definition and run the command.
After the code is generated be sure that all the dependencies are installed. I us VSCodium with Dart extension for that.
If you see a build error see: #4887.
The generated name for the enum values are like:
Suggest a fix
I check the template and all seems correct, the problem should be on the Java generator file on modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/DartClientCodegen.java but I'm not sure of how this work...
The text was updated successfully, but these errors were encountered: