[BUG] Values of instantiationTypes not considered

[Marvin1912]

Bug Report Checklist

• Have you provided a full/minimal spec to reproduce the issue?

openApiGenerate {
    generatorName = 'spring'
    outputDir = "${buildDir}/..."
    inputSpec = "${projectDir}/..."
    apiPackage = "com..."
    invokerPackage = "com..."
    modelPackage = "com..."
    instantiationTypes = [array: "java.util.HashSet"]    
    configOptions = [
            dateLibrary  : "java8",
            interfaceOnly: "true"
    ]
}

• Have you validated the input using an OpenAPI validator (example)?
• What's the version of OpenAPI Generator used?
  4.0.1 (org.openapitools:openapi-generator-gradle-plugin:4.0.1)
• Have you search for related issues/PRs?
• What's the actual output vs expected output?
  Given instantiationTypes = [array: "java.util.HashSet"]
  Actual: ArrayLists are generated
  Expected: Generated HashSets

Description

Wanted to generate HashSets instead of ArrayLists for arrays and set value for instantiationTypes to [array: "java.util.HashSet"]. According to answer of Slack:

Jeremie Bresson vor 16 Stunden
@marvin please create an issue for that, it seems to me that the default value is hard-coded and not using this instantiationTypes parameter.
See:

openapi-generator/modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/AbstractJavaCodegen.java

Lines 718 to 727 in 4575b30

	public String toDefaultValue(Schema p) {
	p = ModelUtils.getReferencedSchema(this.openAPI, p);
	if (ModelUtils.isArraySchema(p)) {
	final ArraySchema ap = (ArraySchema) p;
	final String pattern;
	if (fullJavaUtil) {
	pattern = "new java.util.ArrayList<%s>()";
	} else {
	pattern = "new ArrayList<%s>()";
	}

openapi-generator version

4.0.1, not a regression

OpenAPI declaration file content or url

openApiGenerate {
    generatorName = 'spring'
    outputDir = "${buildDir}/..."
    inputSpec = "${projectDir}/..."
    apiPackage = "com..."
    invokerPackage = "com..."
    modelPackage = "com..."
    instantiationTypes = [array: "java.util.HashSet"]    
    configOptions = [
            dateLibrary  : "java8",
            interfaceOnly: "true"
    ]
}

Command line used for generation

gradle clean openApiGenerate

Steps to reproduce

Just set instantiationTypes according to example above.

Related issues/PRs

Suggest a fix

[jmini]

I am not sure if the instantiationTypes were ever used for default value, but this would be a great addition (more a feature than a bug).

---

I think it is safe to replace:

openapi-generator/modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/AbstractJavaCodegen.java

Lines 722 to 727 in 4575b30

	final String pattern;
	if (fullJavaUtil) {
	pattern = "new java.util.ArrayList<%s>()";
	} else {
	pattern = "new ArrayList<%s>()";
	}

With:
final String pattern = "new " + instantiationTypes().get("array") + "<%s>()";

---

And:

openapi-generator/modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/AbstractJavaCodegen.java

Lines 746 to 751 in 4575b30

	final String pattern;
	if (fullJavaUtil) {
	pattern = "new java.util.HashMap<%s>()";
	} else {
	pattern = "new HashMap<%s>()";
	}

With:
final String pattern = "new " + instantiationTypes().get("map") + "<%s>()";

---

Optional: A unit test for this could also be added in AbstractJavaCodegenTest

---

@Marvin1912: Can you file a pull request for that?

[Marvin1912]

Hi @jmini,
seems like I'm not able to push to created feature branch from my current workstation. I'll try it once more when I've switched places.

[ala85]

Hi @Marvin1912, any update on the above? instantiationTypes field is not really helpful at current state for collections other than plain ArrayList.

[Marvin1912]

Hi @ala85
unfortunately I'm not able to push any changes on a feature branch. Unless someone grant me the rights, there's nothing I can do.

[AlexanderUldall]

Hello @wing328 is this something you or another core contributor could assist with?

[wing328]

@Marvin1912 please have a look at https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-submit-a-pr-to-fix-bugs-or-make-enhancements on how to submit a PR with your enhancement.

[Marvin1912]

PR created.

[rgavriel]

Can you please share a link to the PR.
Was it merge? if so, from which version is it available?

[Marvin1912]

#4982

[tiffmaelite]

@Marvin1912 #4982 was merged. Can this issue be closed?

[Marvin1912]

@tiffmaelite Yes, can be closed.