Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cpp] pass arguments as const reference #272

Closed
MartinDelille opened this issue Jun 10, 2018 · 4 comments
Closed

[cpp] pass arguments as const reference #272

MartinDelille opened this issue Jun 10, 2018 · 4 comments

Comments

@MartinDelille
Copy link
Contributor

MartinDelille commented Jun 10, 2018

Description

Passing arguments as const reference would allow developer not caring about memory issues and would reduce the generated code.

openapi-generator version

Head

OpenAPI declaration file content or url

N/A

Command line used for generation
Steps to reproduce
Related issues/PRs
Suggest a fix/enhancement

#264 #270 #273

@etherealjoy
Copy link
Contributor

I would add here in general also the handling of setters for complex types

@stkrwork
Copy link
Contributor

This issue relates to that #273

@MartinDelille
Copy link
Contributor Author

To #270 too

@etherealjoy
Copy link
Contributor

etherealjoy commented Jul 28, 2018

I applied this to the Qt5 server, but for the client we have to rewrite the helpers since the serialization is dependent on the pass by pointer.

I applied this to Pistache based on @stkrwork initial changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants