Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG][JAVA] Error in generation of defaults for arrays for specific number types #14690

Closed
5 of 6 tasks
robbertvanwaveren opened this issue Feb 14, 2023 · 0 comments · Fixed by #14694
Closed
5 of 6 tasks

Comments

@robbertvanwaveren
Copy link
Contributor

robbertvanwaveren commented Feb 14, 2023

Bug Report Checklist

  • Have you provided a full/minimal spec to reproduce the issue?
  • Have you validated the input using an OpenAPI validator (example)?
  • Have you tested with the latest master to confirm the issue still exists?
  • Have you searched for related issues/PRs?
  • What's the actual output vs expected output?
  • [Optional] Sponsorship to speed up the bug fix or feature request (example)
Description

When an array of default items is specified for a number, the type is infered to BigDecimal but not for the default values.

openapi-generator version

regression since 6.3.0 (probably since #14130 was merged)

OpenAPI declaration file content or url
openapi: 3.0.2
info:
  title: Bug
  version: 0.0.1
paths:
  /test:
    post:
      requestBody:
        content:
          application/json:
            schema:
              type: object
              properties:
                test:
                  type: array
                  items:
                    type: number
                  default:
                    - 0.25
                    - 48
      responses:
        '200':
          description: Ok
Generation Details

openapi-generator-cli generate -i bigdecimal-issue.yaml -g java -o bd-issue

results in TestPostRequest.java

with line 69 being:

this.test = new ArrayList<>(Arrays.asList(0.25, 48));

instead of:

this.test = new ArrayList<>(Arrays.asList(new BigDecimal("0.25"), new BigDecimal("48"));
Steps to reproduce

see above

Related issues/PRs

regression since 6.3.0 (probably since #14130 was merged)

Suggest a fix

See linked PR #14694

@robbertvanwaveren robbertvanwaveren changed the title [BUG][JAVA] Description [BUG][JAVA] Error in generation of defaults for arrays for specific number types Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant