Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Objectmapper instance should not be created per api client invocation. #11686

Open
XI1998-swapnilmarathe opened this issue Feb 22, 2022 · 0 comments

Comments

@XI1998-swapnilmarathe
Copy link

Objectmappers are heavy according to what I have read. Instead it is encouraged to use ObjectReader and ObjectWriter as lightweight alternatives.

For now, we suggest to create new APIClient per thread as its not thread safe. This will also result in creation of new object mapper per invocation.

ref:

image

image

For some cases, objectmapper is not configurable, for that we can allow setting mapper in apiclient via setters.

Can we add this improvement in future?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant