Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Options for merging datasets #17

Closed
rhiaro opened this issue Feb 19, 2024 · 4 comments
Closed

Options for merging datasets #17

rhiaro opened this issue Feb 19, 2024 · 4 comments
Assignees

Comments

@rhiaro
Copy link
Collaborator

rhiaro commented Feb 19, 2024

Simplest is to ask the user to pick one to retain (all data from network A, or all data from network B, no merging/combining).

Set the option for the whole network, or allow user to choose per node/span?

More complicated, so determine if this is useful enough:

  • Fill in missing data from one network which is present in the other network (always? sometimes? depends on field? ask user?)
  • Merge fields which are amenable to being merged, eg. arrays (always? sometimes? depends? ask?)
  • How to combine fields which are single values? (depends? ask?)
@rhiaro
Copy link
Collaborator Author

rhiaro commented Feb 19, 2024

Related: #10

@R2ZER0
Copy link
Collaborator

R2ZER0 commented Apr 5, 2024

I'm thinking, for a simple first implementation, of allowing the user to choose which node/span info to keep whenever they decide as duplicate? E.g. three buttons "Keep A" "Keep Both" "Keep B"

@R2ZER0
Copy link
Collaborator

R2ZER0 commented Apr 5, 2024

As for merging amenable fields i.e. arrays, I guess we could do that by default. Maybe have a checkbox to not?

@rhiaro
Copy link
Collaborator Author

rhiaro commented Apr 18, 2024

Discussion with @R2ZER0 and @odscjen:

We should combine arrays in the consolidated output for:

  • networkProviders
  • technologies
  • transmissionMedium
  • internationalConnections

If we're saying this is one cable, these make sense to merge.

@rhiaro rhiaro closed this as completed Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants