Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/stac 1.1.0 #103

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Feature/stac 1.1.0 #103

wants to merge 3 commits into from

Conversation

clausmichele
Copy link
Member

WIP to support STAC 1.1.0

  • Added some missing fields required in STAC 1.1.0. Changed srs variable to String for wider compatibility.

@pierocampa pierocampa self-requested a review November 22, 2024 08:41
@pierocampa pierocampa self-assigned this Nov 22, 2024
@pierocampa pierocampa added the enhancement New feature or request label Nov 22, 2024
@pierocampa
Copy link
Member

@clausmichele : unit tests are ok, I integrated the changes to keep the coherence of the model objects, and did an actual rebase, so beware that you need to freshly reset to the new HEAD of the branch in case you need to continue developing here.

Regarding the nama of the PR: I see that the reference_system element of a Dimension has been "flexible" (int, String, or Object) eversince the definition of the STAC datacube extension:
https://github.com/stac-extensions/datacube/tree/v1.0.0?tab=readme-ov-file#dimension-object

Do we want to actually upgrade to STAC 1.1.0 for other reasons?

@pierocampa
Copy link
Member

Here's the changes that need to be applied to comply with STAC 1.1.0:
https://github.com/radiantearth/stac-spec/blob/v1.1.0/CHANGELOG.md

@pierocampa
Copy link
Member

NOTE: also beware that the STAC version that is implemented in the Spring Driver is still 0.9.0, so for those collections not imported as-is from STAC backends, that is the version currently adopted.

@pierocampa
Copy link
Member

@clausmichele can we also discard the feature/stac_results branch? It looks like a duplicate of feature/stac_1.1.0

@m-mohr
Copy link
Member

m-mohr commented Dec 13, 2024

Also note that in addition to STAC 1.1.0, there were important updates in the extensions projection, eo and raster.

@pierocampa
Copy link
Member

Thanks Matthias. We could include these to the PR.

Handy changelogs:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants