Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check proposal status of processes #301

Open
m-mohr opened this issue Nov 15, 2021 · 4 comments · Fixed by #419
Open

Check proposal status of processes #301

m-mohr opened this issue Nov 15, 2021 · 4 comments · Fixed by #419

Comments

@m-mohr
Copy link
Member

m-mohr commented Nov 15, 2021

A process can change to stable status with the following requirements:

Processes will only be moved from proposals to the stable process specifications once there are at least two implementations and an example process in the examples folder showing it in a use case. This doesn't require a PSC vote individually as it's not a breaking change, just an addition.

I need to check how many implementations are available and check for (and add) examples.

Related to: https://github.com/openEOPlatform/architecture-docs/issues/21#issuecomment-969134299, where we may want to get the following processes stable:

  • array_concat
  • array_create

Debatable due to missing implementations as of now:

  • array_modify
  • nan
  • is_infinite
@m-mohr m-mohr added this to the 1.2.0 milestone Nov 15, 2021
@m-mohr m-mohr self-assigned this Nov 15, 2021
@m-mohr
Copy link
Member Author

m-mohr commented Nov 16, 2021

None of them qualifies right now.

@m-mohr m-mohr removed their assignment Nov 16, 2021
@m-mohr m-mohr modified the milestones: 1.2.0, 1.3.0 Nov 16, 2021
@clausmichele
Copy link
Member

I will check with EODC if we can port there aggregate_spatial_window. In that case it would be available at Eurac and EODC.

@m-mohr
Copy link
Member Author

m-mohr commented Nov 30, 2021

Thanks @clausmichele. EODC and EURAC would share the same underlying code, right? I'm trying to get to two distinct implementations (i.e. different code/libraries used) so that we can ensure it's somewhat possible to implement in different environments. Sharing (mostly) the same underlying implementation and exposing at two back-ends should not necessarily qualify as two implementations. :-)

@m-mohr m-mohr modified the milestones: 1.3.0, 2.0.0 Feb 1, 2023
@m-mohr
Copy link
Member Author

m-mohr commented Mar 10, 2023

The following processes would qualify to get stable (ignoring the outdated "examples" requirement):

  • array_append (S, V)
  • array_concat (EO, S, V)
  • array_interpolate_linear (EU, S, V)
  • array_create (EO, S, V)
  • resample_cube_temporal (EU, SH)

EO = EODC, EU = EURAC, V = VITO, S = SentinelHub

As such I'd propose to make the 5 processes above stable in 2.0.0.

These also apply, but are still somewhat experimental due to varying implementations or open issues:

  • atmospheric_correction
  • ard_normalized_radar_backscatter
  • load_result
  • sar_backscatter

These also apply, but are expected to change due to improvements to general ML handling #396:

  • fit_class_random_forest
  • fit_regr_random_forest
  • fit_curve
  • load_ml_model
  • predict_curve
  • predict_random_forest
  • save_ml_model

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants