Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feedback]: README has incomplete information for configuring server worker #42

Open
bmulholland opened this issue Aug 22, 2023 · 0 comments

Comments

@bmulholland
Copy link

bmulholland commented Aug 22, 2023

What's on your mind?

Under Init Options, only serviceWorkerParam and serviceWorkerPath are mentioned, not path. But the init source code actually requires path for these to work! The instructions should clearly talk about all the params, which are required, and why.

Also, the instructions aren't clear about how to use those params -- is the serviceWorkerPath relative to the directory in the serviceWorkerParam scope? Absolute? Should the serviceWorkerPath include the name of the JS file? And with the addition of path, how does that connect with the other? What's the intended difference between path and serviceWorkerPath?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant