Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(email): add the missing REST API parameter disable_email_click_tracking #95

Conversation

CHC383
Copy link

@CHC383 CHC383 commented Jan 9, 2025

close #61

Description

One Line Summary

Add the missing REST API parameter disable_email_click_tracking

Details

Motivation

The parameter of the REST API create email message disable_email_click_tracking (https://documentation.onesignal.com/reference/email#disable_email_click_tracking) is missing in the Notification model. Without this users won't be able to disable link tracking using the node api sdk, which is important for transactional emails and could affect email inbox placement.

Scope

Links in emails are not wrapped with trackable links when disable_email_click_tracking is set to true, not enabled by default.

OPTIONAL - Other

Testing

Manual testing

  • npm run prepare
  • The changes are tested by patching the distributed @onesignal/node-onesignal js and d.ts files through pnpm, but not on the repository itself as I am not sure about the testing process.

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

@CHC383
Copy link
Author

CHC383 commented Jan 9, 2025

Per #61 (comment), the SDK needs to be fixed in an upstream project.

@CHC383 CHC383 closed this Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Missing support for critical email features
2 participants