feat(email): add the missing REST API parameter disable_email_click_tracking #95
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #61
Description
One Line Summary
Add the missing REST API parameter disable_email_click_tracking
Details
Motivation
The parameter of the REST API create email message
disable_email_click_tracking
(https://documentation.onesignal.com/reference/email#disable_email_click_tracking) is missing in the Notification model. Without this users won't be able to disable link tracking using the node api sdk, which is important for transactional emails and could affect email inbox placement.Scope
Links in emails are not wrapped with trackable links when
disable_email_click_tracking
is set totrue
, not enabled by default.OPTIONAL - Other
Testing
Manual testing
npm run prepare
@onesignal/node-onesignal
js and d.ts files throughpnpm
, but not on the repository itself as I am not sure about the testing process.Checklist
Overview
Testing
Final pass