Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Formatting the code #206

Closed
szepeviktor opened this issue Jul 27, 2019 · 4 comments
Closed

Formatting the code #206

szepeviktor opened this issue Jul 27, 2019 · 4 comments

Comments

@szepeviktor
Copy link

szepeviktor commented Jul 27, 2019 •
edited
Loading

Hello!

Please consider formatting the code according to WPCS, it takes 3 minutes, e.g.

vendor/bin/phpcs --standard=WordPress-Core onesignal-widget.php

That way you spot errors much easier!
@szepeviktor
Copy link
Author

and vendor/bin/phpcs --standard=WordPress-Extra onesignal-widget.php tells you where to secure the code

@szepeviktor
Copy link
Author

szepeviktor commented Jul 27, 2019 •
edited
Loading 

$ vendor/bin/phpcbf --standard=WordPress-Core onesignal-admin.php

PHPCBF RESULT SUMMARY
------------------------------------------------------------------------------------
FILE                                                                FIXED  REMAINING
------------------------------------------------------------------------------------
/home/viktor/tmp/OneSignal-WordPress-Plugin/onesignal-admin.php     2150   117
------------------------------------------------------------------------------------
A TOTAL OF 2150 ERRORS WERE FIXED IN 1 FILE
------------------------------------------------------------------------------------

@rgomezp
Copy link
Contributor

rgomezp commented Dec 9, 2019

Hi. Thanks for your suggestion. We have done this and will be reflected in the upcoming version of the plugin. Cheers

@rgomezp rgomezp closed this as completed Dec 9, 2019
@szepeviktor
Copy link
Author

You're welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@szepeviktor @rgomezp