Skip to content

Commit 2d22586

Browse files
author
Daniel Jowett
committed
Reorder HEAD elements so that CSS comes before JavaScript - which is correct and proper
This solves an issue in ftw.colorbox where overlays are not always loaded
1 parent 5328937 commit 2d22586

File tree

2 files changed

+8
-5
lines changed

2 files changed

+8
-5
lines changed

Diff for: docs/HISTORY.txt

+2-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,8 @@ Changelog
44
4.0.6 (unreleased)
55
------------------
66

7-
- Nothing changed yet.
7+
- Reorder HEAD elements so that CSS comes before JavaScript - which is correct and proper
8+
[djowett-ftw]
89

910

1011
4.0.5 (2020-03-16)

Diff for: plonetheme/onegov/resources/rules.xml

+6-4
Original file line numberDiff line numberDiff line change
@@ -38,9 +38,14 @@
3838
<after content="/html/head/title" theme-children="/html/head" />
3939

4040
<after
41-
content="/html/head/base | /html/head/style | /html/head/script | /html/head/link | /html/head/comment()"
41+
content="/html/head/base | /html/head/style | /html/head/link | /html/head/comment()"
4242
theme-children="/html/head"
4343
/>
44+
<after theme-children="/html/head" css:content="#portal-top style"/>
45+
<after theme-children="/html/head" css:content="#portal-top link"/>
46+
47+
<after theme-children="/html/head" content="/html/head/script"/>
48+
<after theme-children="/html/head" css:content="#portal-top script"/>
4449

4550
<!-- Copy html lang -->
4651
<copy attributes="lang" content="/html" theme="/html" />
@@ -49,9 +54,6 @@
4954
<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=5.0, minimum-scale=1.0" />
5055
</replace>
5156

52-
<after theme-children="/html/head" css:content="#portal-top script"/>
53-
<after theme-children="/html/head" css:content="#portal-top style"/>
54-
<after theme-children="/html/head" css:content="#portal-top link"/>
5557

5658
<replace css:content="#portal-logo" css:theme="#portal-logo" />
5759
<replace css:content="#portal-globalnav-wrapper" css:theme="#portal-globalnav" />

0 commit comments

Comments
 (0)