Update Omnisharp-roslyn #5544
Update Omnisharp-roslyn #5544
Conversation
dibarbet
force-pushed
the
update_roslyn
branch
from
4434587 to
7f118df
Compare
| let potentialVersionPart = nameParts[nameParts.length - 1]; | ||
| let versions = findVersions(potentialVersionPart, { loose: true }); | ||
| if (!versions || versions.length == 0) { | ||
| if (fileName.startsWith("omnisharp")) { |
There was a problem hiding this comment.
the old code was super busted, trying to convert non semver versions to semver. When the Razor versions changed in https://github.com/OmniSharp/omnisharp-vscode/pull/5523/files (to remove the preview number in their version) the findVersions package started adding an extraneous '.0' at the end. This broke the update script.
I changed this to instead define explicitly what its looking for so at least its more clear on what is going wrong when version numbers change.
The whole format of these dependency sections in the package.json should probably change so we don't have to parse URLs with random versions for file names, but I don't have time for that at the moment.
There was a problem hiding this comment.
When you say semvar, do you mean semver?
There was a problem hiding this comment.
yeah, it was late and I got the wrong word in my head 😆
update log
dibarbet
force-pushed
the
update_roslyn
branch
from
7f118df to
64251dd
Compare
No description provided.