Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update debugger to 1.25.1 #5415

Merged
merged 1 commit into from
Oct 21, 2022
Merged

Conversation

gregg-miskelly
Copy link
Contributor

@gregg-miskelly gregg-miskelly commented Oct 21, 2022

This PR updates the debugger to the latest version. This includes all bug fixes that went into 17.4 of Visual Studio. This includes addressing #5290.

I also removed the warning when installing on arm64 macOS that we should have removed long ago.

This PR updates the debugger to the latest version. This includes all bug fixes that went into 17.4 of Visual Studio. This includes addressing dotnet#5290.
@JoeRobich JoeRobich changed the title Update debugger to 1.25.1 Update debugger to 1.25.1 Oct 21, 2022
@JoeRobich
Copy link
Member

None of my cla tricks have worked. Edited the PR title and tried loading https://cla.dotnetfoundation.org/check/OmniSharp/omnisharp-vscode?pullRequest=5415

@gregg-miskelly
Copy link
Contributor Author

@JoeRobich Do you by chance know who I can ping to investigate?

@JoeRobich
Copy link
Member

One suggestion from the dnceng First Responders team chat was to close and reopen the PR. Going to give that a shot before starting a new discussion about this PR.

@JoeRobich JoeRobich closed this Oct 21, 2022
@JoeRobich JoeRobich reopened this Oct 21, 2022
@WardenGnaw
Copy link
Contributor

WardenGnaw commented Oct 21, 2022

@JoeRobich EDIT: Whoops that was the old way.

Can you toggle the branch policy at the bottom of this image?
image

@JoeRobich
Copy link
Member

Are you asking me to make the cla policy non-required? If so, I could just override the requirement and merge.

@JoeRobich
Copy link
Member

Just going to merge it as other checks are green.

@JoeRobich JoeRobich merged commit 6b5b6f8 into dotnet:master Oct 21, 2022
@WardenGnaw
Copy link
Contributor

@JoeRobich I was thinking that if you removed/readded the policy it would reset the connection.

@JoeRobich
Copy link
Member

JoeRobich commented Oct 24, 2022

So I tried removing the license/cla check, saved, and have now added it back. I am still unable to get the CLA check to pass in this other recent PR #5407. Also, seems that it may not be running for omnisharp-roslyn either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants