-
Notifications
You must be signed in to change notification settings - Fork 679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clear all strict mode violations in src & enforce strict mode #5407
Merged
JoeRobich
merged 20 commits into
dotnet:master
from
winstliu:users/winstonliu/full-src-nullability
Oct 27, 2022
Merged
Clear all strict mode violations in src & enforce strict mode #5407
JoeRobich
merged 20 commits into
dotnet:master
from
winstliu:users/winstonliu/full-src-nullability
Oct 27, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can do this as DotnetLaunchPath is only set on the useModernNet path, which also doesn't set anything else, which means we can just fold it into LaunchPath and use that instead.
This is possible via the observation that 1) MonoLaunchPath is exclusively set on the framework + *nix path, and 2) the launcher always prefers MonoLaunchPath on the *nix path. Thus, the separate LaunchPath property is never used, hence we can replace it with MonoLaunchPath's value.
JoeRobich
approved these changes
Oct 27, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all this strictness work! this will be fun to merge into feature/lsp-engine. =)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, the remaining strict changes:
SpawnedChildProcess
, to denote child processes that have successfully spawned and thus have stderr/in/out & pid propertiesSecond, the tsconfig.json/package.json/test changes:
forceConsistentCasingInFileNames
because the Edge Devtools extension was complaining about that)