coreclr-debug nullability #5405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- getDotnetInfo now throws instead of returning a hardcoded message - Removed OsVerson property as it was unused
|
@gregg-miskelly Could you review the debugger code changes? |
gregg-miskelly
approved these changes
Oct 13, 2022
JoeRobich
approved these changes
Oct 13, 2022
| export async function getDotnetInfo(dotNetCliPaths: string[]): Promise<DotnetInfo> { | ||
| if (_dotnetInfo !== undefined) { | ||
| return _dotnetInfo; | ||
| } | ||
|
|
||
| let dotnetExeName = join('dotnet', CoreClrDebugUtil.getPlatformExeExtension()); | ||
| let dotnetExecutablePath: string | undefined = undefined; | ||
| let dotnetExeName = `dotnet${CoreClrDebugUtil.getPlatformExeExtension()}`; |
There was a problem hiding this comment.
Thanks. Not sure what I was thinking.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This handles the coreclr-debug folder. This is the last src folder that needs to be converted; one more PR will follow to address recent changes to the other folders & enable strict mode for all of src.
Behavior changes:
path.joininstead of just string concatenation, resulting in a Windows executable ofdotnet\.exerather thandotnet.exe.Impact:
22 strict violations in src, down from 43 in master. (Fun fact: including test, we're now at 198 strict violations. Below 200!)