Don't create launch.json for no selected process #4699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes resolveDebugConfigurationWithSubstitutedVariables to return null when user does not select a process in the process selection dialog.
WardenGnaw
changed the title
gregg-miskelly
approved these changes
Aug 9, 2021
|
@JoeRobich Are the PR builds broken? My changes should not affect any tests since it should only hit during the scenario when not selecting a process in the dialog during a attach debug. |
I'll investigate. Looks like a project selector change may be the cause. |
|
Thank you @JoeRobich! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes resolveDebugConfigurationWithSubstitutedVariables to
return undefined when user does not select a process in the process selection
dialog.
This will ensure it does not switch to the
launch.jsontab.Related: #4696