Use temporary directory for debug sockets on NIX systems #4637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I haven't investigated much, but this feels like the wrong fix to me -- in your exact case this is going to get you under the limit, but if your user alias would be a bit longer then it wouldn't help. Isn't a better fix to move this under $TMP on OSX? |
|
|
|
Agreed. I have added functionality which overrides socket paths to I apologize in advance if code is not clean, I have not worked with typescript much in the past. |
valters-tomsons
changed the title
gregg-miskelly
requested changes
Jul 1, 2021
gregg-miskelly
approved these changes
Jul 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #4523
This PR stores debug sockets in
/tmp/or$TMPDIR(if set) on Linux & OSX platforms.