Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add path to dotnet so child processes can use the CLI #4459

Merged
merged 5 commits into from
Apr 7, 2021

Conversation

JoeRobich
Copy link
Member

No description provided.

@JoeRobich JoeRobich force-pushed the add-dotnet-to-path branch from 98a9367 to 4fba131 Compare March 26, 2021 01:19
@JoeRobich JoeRobich marked this pull request as ready for review March 26, 2021 01:19
@JoeRobich JoeRobich force-pushed the add-dotnet-to-path branch 2 times, most recently from 164d13a to 220effe Compare March 26, 2021 01:21
@codecov
Copy link

codecov bot commented Mar 26, 2021

Codecov Report

Merging #4459 (2f3b15e) into master (6da0831) will decrease coverage by 0.05%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4459      +/-   ##
==========================================
- Coverage   68.96%   68.91%   -0.06%     
==========================================
  Files         108      109       +1     
  Lines        4273     4282       +9     
  Branches      739      741       +2     
==========================================
+ Hits         2947     2951       +4     
- Misses       1123     1128       +5     
  Partials      203      203              
Flag Coverage Δ
integration 52.56% <80.00%> (+0.03%) ⬆️
unit 85.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/main.ts 84.67% <66.66%> (-0.33%) ⬇️
src/DotnetPack.ts 80.00% <80.00%> (ø)
src/features/semanticTokensProvider.ts 82.00% <100.00%> (ø)
src/features/diagnosticsProvider.ts 77.77% <0.00%> (-3.71%) ⬇️
src/observers/WarningMessageObserver.ts 100.00% <0.00%> (+5.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6da0831...2f3b15e. Read the comment docs.

@JoeRobich
Copy link
Member Author

@nohwnd @vzarytovskii Please review.

@JoeRobich JoeRobich force-pushed the add-dotnet-to-path branch 2 times, most recently from 8062440 to dffd50b Compare April 6, 2021 23:12
@JoeRobich JoeRobich force-pushed the add-dotnet-to-path branch from 391cd6a to 4604444 Compare April 6, 2021 23:42
@JoeRobich JoeRobich merged commit b6d16ba into dotnet:master Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant