Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional incremental tweaks #4143

Merged
merged 2 commits into from
Oct 23, 2020
Merged

Additional incremental tweaks #4143

merged 2 commits into from
Oct 23, 2020

Conversation

333fred
Copy link
Member

@333fred 333fred commented Oct 23, 2020

My previous incremental change wasn't quite right, and causes files that are not currently opened to never be reloaded. This corrects that change by only skipping file changed on disk events when the file is opened by vscode, meaning that it has an active TextDocument that will be triggered for changes.

My previous incremental change wasn't quite right, and causes files that are not currently opened to never be reloaded. This corrects that change by only skipping file changed on disk events when the file is opened by vscode, meaning that it has an active TextDocument that will be triggered for changes.
@333fred 333fred requested a review from JoeRobich October 23, 2020 22:58
@codecov
Copy link

codecov bot commented Oct 23, 2020

Codecov Report

Merging #4143 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4143   +/-   ##
=======================================
  Coverage   85.99%   85.99%           
=======================================
  Files          60       60           
  Lines        1857     1857           
  Branches      215      215           
=======================================
  Hits         1597     1597           
  Misses        200      200           
  Partials       60       60           
Flag Coverage Δ
#integration ?
#unit 85.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc072c5...d89fb12. Read the comment docs.

@JoeRobich JoeRobich merged commit 5cee5c3 into dotnet:master Oct 23, 2020
@333fred 333fred deleted the master branch June 13, 2023 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants