Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not send file changed events for .cs files #4141

Merged
merged 3 commits into from
Oct 23, 2020

Conversation

333fred
Copy link
Member

@333fred 333fred commented Oct 23, 2020

Similar to the rename and codeAction change, this can cause incremental updates to break if the file is updated on disk (not by a vscode edit).

Similar to the rename and codeAction change, this can cause incremental updates to break if the file is updated on disk (not by a vscode edit).
Copy link
Member

@JoeRobich JoeRobich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

src/features/changeForwarding.ts Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 23, 2020

Codecov Report

Merging #4141 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4141   +/-   ##
=======================================
  Coverage   85.99%   85.99%           
=======================================
  Files          60       60           
  Lines        1857     1857           
  Branches      215      215           
=======================================
  Hits         1597     1597           
  Misses        200      200           
  Partials       60       60           
Flag Coverage Δ
#integration 100.00% <ø> (ø)
#unit 85.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0201fb5...f2e3295. Read the comment docs.

@JoeRobich JoeRobich merged commit bc072c5 into dotnet:master Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants