Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setting for enabling go to decompilation. #3774

Merged
merged 2 commits into from
May 11, 2020

Conversation

JoeRobich
Copy link
Member

@JoeRobich JoeRobich commented May 11, 2020

This option works just like the Visual Studio counterpart.

There is a single application wide setting to enable decompilation support ('omnisharp.enableDecompilationSupport'). Then for each workspace you access there is a terms agreement which must be acknowledged. This acknowledgement will persist between sessions for the workspace. If there is need to change how the terms were acknowledged, a command is added to display the decompilation terms prompt ('csharp.showDecompilationTerms') for the open workspace.

image

@JoeRobich JoeRobich force-pushed the add-decompilation-option branch 2 times, most recently from 607af72 to 48418d7 Compare May 11, 2020 18:36
@JoeRobich JoeRobich mentioned this pull request May 11, 2020
@JoeRobich JoeRobich force-pushed the add-decompilation-option branch from 48418d7 to 73654d1 Compare May 11, 2020 18:53
@codecov
Copy link

codecov bot commented May 11, 2020

Codecov Report

Merging #3774 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3774      +/-   ##
==========================================
+ Coverage   87.00%   87.01%   +0.01%     
==========================================
  Files          59       59              
  Lines        1777     1779       +2     
  Branches      209      207       -2     
==========================================
+ Hits         1546     1548       +2     
  Misses        176      176              
  Partials       55       55              
Flag Coverage Δ
#integration 100.00% <ø> (ø)
#unit 87.01% <100.00%> (+0.01%) ⬆️
Impacted Files Coverage Δ
src/observers/OptionChangeObserver.ts 100.00% <100.00%> (ø)
src/omnisharp/options.ts 94.18% <100.00%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b90e961...371eaa5. Read the comment docs.

@JoeRobich JoeRobich removed the Blocked label May 11, 2020
@JoeRobich JoeRobich merged commit 65168f8 into dotnet:master May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants