Update Razor to work for 3.1 SDKs #3406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
NTaylorMullen
commented
Nov 14, 2019
NTaylorMullen
commented
- These bits include a new Razor language server, O# plugin and VSCode extension that update the Razor experience to work on 3.1 DSKs
- These bits include a new Razor language server, O# plugin and VSCode extension that update the Razor experience to work on 3.1 DSKs
filipw
approved these changes
Nov 14, 2019
| @@ -30,7 +30,7 @@ | |||
| ], | |||
| "defaults": { | |||
| "omniSharp": "1.34.7", | |||
| "razor": "1.0.0-alpha3-20190819.3" | |||
| "razor": "1.0.0-alpha3-3.1.0-preview3.19563.3" | |||
There was a problem hiding this comment.
Kind of ya. We moved where we build the Razor VSCode extension pieces into AspNetCore-Tooling and as part of that the versioning changed a lot.
JoeRobich
approved these changes
Nov 14, 2019
|
Feel free to merge on my behalf when the repo is ready for it 😄 |
Codecov Report
@@ Coverage Diff @@
## master #3406 +/- ##
=======================================
Coverage 89.81% 89.81%
=======================================
Files 59 59
Lines 1591 1591
Branches 89 89
=======================================
Hits 1429 1429
Misses 151 151
Partials 11 11
Continue to review full report at Codecov.
|
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.