Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dispose the disposables in a finally block #2405

Merged
merged 1 commit into from
Jul 3, 2018

Conversation

akshita31
Copy link
Contributor

Issue: #2400

In dotnetTest file we are not TestMessage listener using a try-finally block due to which when there is an exception, the listener still remains and when the next time the debugger starts, there are multiple listeners which make the logs look very clumsy.

@rchande
Copy link

rchande commented Jul 3, 2018

@akshita31 Do we really want the changes made to package-lock.json?

@codecov
Copy link

codecov bot commented Jul 3, 2018

Codecov Report

Merging #2405 into master will decrease coverage by 0.06%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2405      +/-   ##
=========================================
- Coverage   62.56%   62.5%   -0.07%     
=========================================
  Files          87      87              
  Lines        3876    3880       +4     
  Branches      552     552              
=========================================
  Hits         2425    2425              
- Misses       1287    1291       +4     
  Partials      164     164
Flag Coverage Δ
#integration 51.65% <0%> (-0.06%) ⬇️
#unit 84.26% <ø> (ø) ⬆️
Impacted Files Coverage Δ
src/features/dotnetTest.ts 11.32% <0%> (-0.22%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3145af...3e45246. Read the comment docs.

Copy link

@rchande rchande left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved except for package-lock changes

@akshita31 akshita31 merged commit 671e602 into dotnet:master Jul 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants