Move project.json dependency completion & hover to vscode-omnisharp #1236
Conversation
…thub.com/aeschli/omnisharp-vscode into aeschli-aeschli/project-json-dependency-supports
|
Hey @aeschli: Both jsonc-parser and request-light appear to be designed for VS Code extension authors. Is there a list somewhere of packages intended for VS Code extensions? |
| @@ -33,9 +33,11 @@ | |||
| "fs-extra": "^1.0.0", | |||
| "http-proxy-agent": "^1.0.0", | |||
| "https-proxy-agent": "^1.0.0", | |||
| "jsonc-parser": "^0.3.0", | |||
There was a problem hiding this comment.
Do we need to update our ThirdPartyNotices.txt for this?
|
Any comments here @aeschli? |
|
@DustinCampbell Good point, we don't have such a list. I created microsoft/vscode-docs#846 |
|
jsonc-parser and request-light are both owned by Microsoft. No need to list in the ThirdPartyNotices. |
|
@gregg-miskelly: Any other feedback? If not, I'm going to go ahead and take this so that @aeschli can remove the code on the VS Code side for their March release. @aeschli: Currently, I find that this causes duplicate hover tooltips due to having HoverProviders in both VS Code and C# for VS Code. However, the experience isn't too terrible, and it's a point in time problem. |
| 'version': '{{1.0.0-*}}', | ||
| 'dependencies': {}, | ||
| 'frameworks': { | ||
| 'dnx451': {}, |
There was a problem hiding this comment.
Should we update these to something more modern?
There was a problem hiding this comment.
Yes. We can do it later though. These will still work for now.
|
@aeschli: Could you cc me on the corresponding change in VS Code? |
|
@DustinCampbell I removed the project.json support from VSCode. This will be part of the February release (in about 2 weeks) |
|
Got it. Thanks! |
|
Also, @aeschli, sorry that took so long! |
This change adds the project.json completion and hover support to C# for Visual Studio Code, allowing it to be removed from VS Code.
This PR supersedes #224.
cc @aeschli