-
Notifications
You must be signed in to change notification settings - Fork 676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update package.json #1082
Update package.json #1082
Conversation
Add jsonValidation with prototyped omnisharp
@Thaina: Where did this schema come from? Did you create it from scratch? Could you contribute it to https://github.com/OmniSharp/omnisharp-roslyn? cc @filipw, @david-driscoll? |
I use some tool that automatically generate schema from default json. I pick default formatting from some omnisharp repo |
it's from here SchemaStore/schemastore#260 |
Shouldn't we add this to the omnisharp-roslyn repo so we can keep it up-to-date? |
It could even be generated dynamically with JSON.NET based on the object definitions at build time |
Thanks! |
Now that we've got that out of the way... @Thaina, could you use spaces rather than tabs so that your change matches the rest of the file? |
Again, please make it looks like the rest of the file. You've indented too far. 😄 Sorry for being pedantic. 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much better. Thank you for being patient!
Add jsonValidation with prototyped omnisharp