Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Add support of exception filters #4356

Closed
vchirikov opened this issue Jan 20, 2021 · 7 comments
Closed

[Feature Request]: Add support of exception filters #4356

vchirikov opened this issue Jan 20, 2021 · 7 comments

Comments

@vchirikov
Copy link

Hi, it's really huge feature for any developer and I miss it so much in vs code.

@gregg-miskelly
Copy link
Contributor

We are currently waiting on microsoft/debug-adapter-protocol#164, but agreed that this would be a very useful feature to add.

@vchirikov
Copy link
Author

microsoft/debug-adapter-protocol#164 is merged 🎉

@gregg-miskelly
Copy link
Contributor

gregg-miskelly commented Apr 14, 2021

This is fixed in 1.23.12. See https://aka.ms/VSCode-CS-ExceptionSettings for documentation.

@vchirikov
Copy link
Author

@gregg-miskelly Recently I tried to use few exception filters, but seems that the only one negative filter can be applied.
So, for example:

  • !System.Threading.Tasks.TaskCanceledException,!Confluent.Kafka.Admin.CreateTopicsException doesn't work
  • !Confluent.Kafka.Admin.CreateTopicsException works fine.

I think we need something to exclude several types of exceptions.

@gregg-miskelly
Copy link
Contributor

Your entire filter is either an include list or an exclude list. So the exclamation mark just goes at the start.

@vchirikov
Copy link
Author

@gregg-miskelly thank you and sorry for distraction, it was not obvious to me

@gregg-miskelly
Copy link
Contributor

gregg-miskelly commented Apr 19, 2021

@vchirikov No problem. Thanks for asking the question. If it was confusing to you the documentation should probably be improved. I opened #4505 to add another example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants