Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

launch.json template should switch from 'command.' to 'command:' #1275

Closed
gregg-miskelly opened this issue Mar 2, 2017 · 2 comments
Closed

launch.json template should switch from 'command.' to 'command:' #1275

gregg-miskelly opened this issue Mar 2, 2017 · 2 comments
Assignees
@gregg-miskelly
Labels
Debugger Resolved-Fixed
Milestone
1.8

Comments

@gregg-miskelly
Copy link
Contributor

In VS Code 1.10, the ${command. was deprecated, and gives a warning to switch to ${command:. But our templates still use the '.' version.
@gregg-miskelly gregg-miskelly added this to the 1.8 milestone Mar 2, 2017
@chuckries
Copy link
Contributor

Do we need to update our minimum VS Code version with this fix as well?

@gregg-miskelly
Copy link
Contributor Author

I think so. We will be doing so with the vsdbg work anyway, so I don't see any downside of doing that.

@gregg-miskelly gregg-miskelly self-assigned this Mar 3, 2017
gregg-miskelly added a commit to gregg-miskelly/vscode-csharp that referenced this issue Mar 3, 2017
@gregg-miskelly
launch.json fixes for 'cwd' and '${command.'
a54d935 
This resolves:
dotnet#1275
dotnet#1083
@gregg-miskelly gregg-miskelly mentioned this issue Mar 3, 2017
Merged
This was referenced Mar 3, 2017
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gregg-miskelly gregg-miskelly

Labels
Debugger Resolved-Fixed
Projects
None yet
Milestone
1.8
Development

No branches or pull requests
2 participants
@chuckries @gregg-miskelly