Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.6.0 for VSCode reintroduced the syntax bug for escape double quote #1078

Closed
xuzf-thl opened this issue Dec 22, 2016 · 7 comments
Closed

1.6.0 for VSCode reintroduced the syntax bug for escape double quote #1078

xuzf-thl opened this issue Dec 22, 2016 · 7 comments

Comments

@xuzf-thl
Copy link

xuzf-thl commented Dec 22, 2016

VS Code version: 1.7.1
C# Extension version: 1.6.0

Steps to reproduce

in a .cs file, if the string as an escape double quote \", Omnisharp will not show proper syntax for the code following it.
Like the code below:

            configContent = rgx.Replace(configContent, $"name{suffix}\"");
            File.WriteAllText(_testConfigFile, configContent);
        }

Note: C# Extension version 1.5.3 doesn't have this bug.

Expected behavior

the code after \" should still show the proper syntax.

Actual behavior

the code after it shows as string, until the next double quote.

@DustinCampbell
Copy link
Member

Thanks for taking the time to report this issue!

cc @ivanz

@DustinCampbell DustinCampbell added this to the 1.7 milestone Dec 22, 2016
@ivanz
Copy link
Contributor

ivanz commented Dec 23, 2016

Will fix this and add some tests when I am back from holidays in a week or so 👍

@aadnehovda
Copy link

Same issue, another example:
image

@DustinCampbell
Copy link
Member

I'll have fixes for this in the near future.

@DustinCampbell
Copy link
Member

Both of these examples should be working in the next release:

image

image

@xuzf-thl
Copy link
Author

xuzf-thl commented Feb 2, 2017

for reference: this bug was reported and fixed before: #442

@DustinCampbell
Copy link
Member

The bug regressed. This is fixed properly now and tests are in place to ensure it doesn't return. We've written a completely new TextMate grammar for C# that is much more robust than what shipped previously.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants