Open C# colorizing issues

[aeschli]

FYI I created the following bugs against https://github.com/atom/language-csharp from issues reported against the c# snytax highlighting in VS Code.
I will close the corresponding bugs in the VSCode repository that we kept open to track any progress.

atom/language-csharp#48
atom/language-csharp#46
atom/language-csharp#43
atom/language-csharp#44
atom/language-csharp#45

[ivanz]

@DustinCampbell FYI All but one of those are fixed and I have created a separate issue for it here #687 - so you can close this one. I have an idea how to fix the remaining one and will have a look when I get a chance.

[DustinCampbell]

@ivanz, do you think it'd make sense to port your fixes over to the (https://github.com/atom/language-csharp) repo?

[DustinCampbell]

cc @david-driscoll as well. I'm not sure if the OmniSharp extension for Atom uses the same grammar or not.

[david-driscoll]

Yeah, we use the built in csharp grammar from atom. The semantic highlighting is additive.

[DustinCampbell]

Cool. So, porting these fixes to atom would be good for you too.

[david-driscoll]

If you port them (which would be amazing!) feel free to cc me on the pull request. 👍

[DustinCampbell]

All of these are fixed for the next release.

[joshpritchard-fcx]

This release did not fix microsoft/vscode#848 so it should be re-opened. This is very annoying for me.

[DustinCampbell]

@joshpritchard-fcx : Here's what the microsoft/vscode#848 repro looks like it the latest release of VS Code:

This appears to be correct to me. If you disagree, please feel free to file a new issue at https://github.com/dotnet/csharp-tmLanguage/issues.

[joshpritchard-fcx]

Thanks. Sorry for commenting here I guess what I am seeing is a separate issue.