Provide SourceGeneratedFileInfo for workspace symbols requests #2431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the workspace symbols requests to provide a SourceGeneratedFileInfo when the symbol is from a source generated file, so aware editors can retrieve information about the file and display it correctly, rather than showing no information.
333fred
added a commit
to 333fred/vscode-csharp
that referenced
this pull request
Aug 12, 2022
VSCode side of OmniSharp/omnisharp-roslyn#2431. I also updated the source generated doc provider to have a lazy-fetch option, as we don't want to fetch and cache generated files for every single symbol that gets returned in a workspace symbol request.
|
@JoeRobich @filipw for review. |
333fred
commented
Aug 12, 2022
| }; | ||
| } | ||
|
|
||
| internal static SourceGeneratedFileInfo? GetSourceGeneratedFileInfo(Solution solution, Location location) |
There was a problem hiding this comment.
Copy/paste from GoToDefinitionHelpers, and modified to take a Solution instead of an OmniSharpWorkspace.
There was a problem hiding this comment.
I believe this was intended to be the home for extension methods, so maybe it would be good to make this one too for consistency
filipw
previously approved these changes
Aug 12, 2022
|
@filipw any other comments? |
333fred
changed the title
333fred
added a commit
to dotnet/vscode-csharp
that referenced
this pull request
Aug 13, 2022
VSCode side of OmniSharp/omnisharp-roslyn#2431. I also updated the source generated doc provider to have a lazy-fetch option, as we don't want to fetch and cache generated files for every single symbol that gets returned in a workspace symbol request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the workspace symbols requests to provide a SourceGeneratedFileInfo when the symbol is from a source generated file, so aware editors can retrieve information about the file and display it correctly, rather than showing no information.