Pass the logger for loading projects. So errors occur in loading projects can be printed out. #2288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
…ects can be printed out. omnisharp-vscode issue #4832
|
Thanks. Do you have an example of this change - logs before and after? |
|
@filipw this PR is to address the issue Some key error info missing when failed in loading some projects, in which situation it's no way to figure out what's exactly going wrong. Log examples before and after the change are hereOmniSharp Log before the changeOmniSharp log after the change, containing the info of specific missing .NET SDK version in its error messages |
|
Looks like the difference in this case are the following lines. [info]: OmniSharp.Stdio.Host
Omnisharp server running using Stdio at location 'c:\Source\GitHub\ILSpy' on host 45896.
[info]: OmniSharp.MSBuild.ProjectManager
Loading project: c:\Source\GitHub\ILSpy\ICSharpCode.Decompiler\ICSharpCode.Decompiler.csproj
+ [fail]: OmniSharp.MSBuild.ProjectLoader
+ C:\Program Files\dotnet\sdk\5.0.100\Sdks\Microsoft.NET.Sdk\Sdk not found. Check that a recent enough .NET SDK is installed and/or increase the version specified in global.json.
+ [fail]: OmniSharp.MSBuild.ProjectLoader
+ The SDK 'Microsoft.NET.Sdk' specified could not be found.
[fail]: OmniSharp.MSBuild.ProjectManager
Failed to load project file '{projectFilePath}'.
Microsoft.Build.Exceptions.InvalidProjectFileException: The SDK 'Microsoft.NET.Sdk' specified could not be found. c:\Source\GitHub\ILSpy\ICSharpCode.Decompiler\ICSharpCode.Decompiler.csproj |
|
That looks good then 👍 |
|
There 2 checks failed due to no enough space on the build server's disk. |
|
@cateyes99 Thanks. We are looking into it. This seems to be a result of merging the vnext branch into master which increased the number of artifacts being built. |
|
Tracking a fix in #2293. Once it merges we will need to update this branch with the changes. |
|
This time there r 4 checks fails, among which 3 were actually passed time. Looks odd to me, anyway try to merge the latest master again. |
filipw
approved these changes
Dec 7, 2021
JoeRobich
approved these changes
Dec 7, 2021
|
Thanks @cateyes99 ! |
|
My pleasure 😄 |
cateyes99
deleted the
cateyes99/4832/keyInfoMissing-whenLoadProjectsFailed
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass the logger for loading projects. So errors occur in loading projects can be printed out.
omnisharp-vscode issue #4832