Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix completion on part of existing string #1941

Merged
merged 5 commits into from
Sep 28, 2020
Merged

Fix completion on part of existing string #1941

merged 5 commits into from
Sep 28, 2020

Commits on Sep 14, 2020

  1. Fix completion on part of existing string

    @nohwnd
    nohwnd committed Sep 14, 2020
    Configuration menu
    Copy the full SHA
    a329ce5 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2020

  1. Use text edit for main insert text 

    Because I misread the LSP spec when imlementing completion, I didn't realize that InsertTextFormat applied to both InsertText, and to the NewText property of the main TextEdit of a completion item. This latter version is much more robust to casing issues than using InsertText directly, and ensures that matching of completion items in the completion list works better as well. Fixes dotnet/vscode-csharp#4063.
    @333fred
    333fred committed Sep 18, 2020
    Configuration menu
    Copy the full SHA
    e21a232 View commit details
    Browse the repository at this point in the history

  2. Add more tests for override spans within the original typed text, com… 

    …ment with examples on vscode behavior for replacing ranges.
    @333fred
    333fred committed Sep 18, 2020
    Configuration menu
    Copy the full SHA
    255a883 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #1 from 333fred/textedit-completion 

    Use text edit for main insert text
    @nohwnd
    nohwnd authored Sep 18, 2020
    Configuration menu
    Copy the full SHA
    252f79a View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into completion-on-part-of-typed-text

    @nohwnd
    nohwnd authored Sep 18, 2020
    Configuration menu
    Copy the full SHA
    6c2a86f View commit details
    Browse the repository at this point in the history