Check for MSBuild version is higher than required by the .NET SDK #1875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeRobich
changed the title
filipw
approved these changes
Aug 6, 2020
| @@ -64,7 +64,8 @@ public CompositionHost Build() | |||
| // This is for tests, where the MSBuild instance may be registered early. | |||
| if (msbuildLocator.RegisteredInstance == null) | |||
| { | |||
| msbuildLocator.RegisterDefaultInstance(logger); | |||
| var dotNetInfo = dotNetCliService.GetInfo(workingDirectory); | |||
There was a problem hiding this comment.
I am not sure if it's possible to have a different global.json with different SDK versions per project - but I think it is not, so it should be fine to run this against the startup directory
filipw
reviewed
Aug 6, 2020
|
|
||
| var version = dotNetInfo.SdkVersion; | ||
| var sdksPath = dotNetInfo.SdksPath; | ||
| var minimumVersionPath = Path.Combine(sdksPath, version.ToNormalizedString(), "minimumMSBuildVersion"); |
There was a problem hiding this comment.
this is really there?! that's new to me!
There was a problem hiding this comment.
I was happy to find it =)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide a warning when the discovered MSBuild version is lower than the minimumMSBuildVersion supported by the configured SDK.