fixed out of bounds in line mapping #1707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NTaylorMullen
approved these changes
Feb 11, 2020
bjorkstromm
approved these changes
Feb 11, 2020
|
@JoeRobich @david-driscoll any objections? can this be merged? |
JoeRobich
reviewed
Feb 12, 2020
| if (hasMappedPath) | ||
| { | ||
| SourceText source = null; | ||
| if (documents != null && documents.Any() && documents.FirstOrDefault(d => d.TryGetText(out source)) != null) |
There was a problem hiding this comment.
I'm not as familiar with line mappings. Would it be more correct to loop through the documents where you can get text and see if the mapping applies?
There was a problem hiding this comment.
documents.Any() isn't necessary now that you are using FirstOrDefault
There was a problem hiding this comment.
I think this can only ever return more than 1 in case of multi targeting so the document text would be identical
|
|
david-driscoll
approved these changes
Feb 13, 2020
filipw
added a commit
that referenced
this pull request
Feb 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes dotnet/vscode-csharp#3485
Also added more comprehensive tests.
Here is the summary of the logic:
cc @NTaylorMullen as this bug affected Razor 🙈