fixed symbol decoding from completion items #1670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipw
commented
Dec 20, 2019
| @@ -259,6 +259,7 @@ public MyClass2() | |||
|
|
|||
| var completions = await FindCompletionsAsync(filename, source); | |||
| ContainsCompletions(completions.Select(c => c.CompletionText), "Foo"); | |||
| ContainsCompletions(completions.Select(c => c.ReturnType), "string"); | |||
There was a problem hiding this comment.
without the changes from this PR, this assert fails (for example on current master). It would have prevented the regression too.
bjorkstromm
reviewed
Dec 20, 2019
src/OmniSharp.Roslyn.CSharp/Services/Intellisense/CompletionItemExtensions.cs
Outdated
Show resolved
Hide resolved
bjorkstromm
approved these changes
Dec 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This got broken a while ago - around these changes 1f10506. It was fragile, as it's reflection.
It impacts the quality of some of the completion item driven completions, which we don't use a lot but nevertheless - i.e. object initializer, which were missing symbol information.
fixes dotnet/vscode-csharp#3465